harshkha3417 commented on PR #7684: URL: https://github.com/apache/shenyu/pull/7684#issuecomment-6229005036
Thanks for the thorough review and helpful feedback, @Aias00! I've addressed both non-blocking notes in the latest commit: 1. Documented the alias relationship and precedence in the Javadoc for `pendingAcquireMaxCount`. 2. Extracted `validateAndApplyMaxPendingAcquires` to eliminate the duplicate validation between the fixed and elastic pool builders. Checkstyle and all unit tests are passing clean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
