liaochengjie commented on PR #7741: URL: https://github.com/apache/shenyu/pull/7741#issuecomment-6244874243
@Aias00 Thanks for the review. Addressed the follow-up points in e7a4a7dc2e5cf3d197ef626588c7e20d3f109da8: - Added H2 + real-mapper cases for a non-admin whose namespace mapping service returns null, with null, empty, and non-empty names. All three return an empty list. - Kept the existing SQL `LIKE` wildcard semantics intentionally for consistency across user scopes. Added `%` and `_` regression cases for both administrator and regular-user queries, including the regular-user authorization boundary, and documented this decision in the PR description. Literal wildcard matching would require a separate change to the existing filtering contract for both scopes. Local verification passed with Java 17 and the repository Maven Wrapper: 16 selected test cases, with all 28 modules in the scoped `clean verify` build passing Checkstyle and Apache RAT. The exact command is in the updated PR description; this is not a full repository test run. Could a maintainer please approve the workflow runs for this fork PR so `pr_build` can run before merge? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
