harshkha3417 commented on PR #7800: URL: https://github.com/apache/shenyu/pull/7800#issuecomment-6258852157
Thanks @Aias00 for the detailed review and pointers! I've addressed the non-blocking feedback: 1. **NPE guard & root normalization:** `parentTagId` now safely defaults to `AdminConstants.TAG_ROOT_PARENT_ID` (`"0"`) when `null`/empty and uses `AdminConstants.TAG_ROOT_PARENT_ID.equals(parentTagId)`. 2. **Side effect eliminated:** Removed `tagDTO.setParentTagId(...)` mutation; the normalized parent ID is set directly on `tagDO`. 3. **Tests added:** Added `TagServiceTest#testUpdateWithNullParentTagId` and `TagUpdateTransactionTest#testUpdateTagWithoutParentTagIdInDtoPreservesRootExt`. 4. **Rebase:** Rebased on latest `master`, all tests and checkstyle pass cleanly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
