konlue opened a new pull request, #7887: URL: https://github.com/apache/shenyu/pull/7887
> Following up on my [comment from Oct 14](https://github.com/apache/shenyu/issues/7607#issuecomment-6159931513) — proceeding with the narrowed scope proposed there (`commons-io` only), since the issue remains unassigned and unclaimed. Happy to adjust if you'd rather keep `commons-io`. Fixes #7607. ## Summary The issue lists both `commons-io` and `commons-collections4` for removal from `shenyu-admin`. On master, `commons-collections4` is imported by ~65 files (not removable now), so this PR — as proposed in the comment above — only removes `commons-io`, whose entire admin usage is two `IOUtils.copy` calls. ## Modifications - Replace both `IOUtils.copy(...)` call sites with `org.springframework.util.StreamUtils.copy(...)` (`ClusterForwardFilter`, `SandboxServiceImpl`). Identical semantics: buffered copy with both streams left open for the caller. - Remove the `commons-io` dependency from `shenyu-admin/pom.xml` only. The `${commons-io.version}` property stays — `shenyu-plugin-cryptor` and `shenyu-protocol-tcp` still reference it. ## Verifying this change - [x] Targeted tests pass (`-pl shenyu-admin -am`): ```bash # ClusterForwardFilterTest 4/4 green # SandboxServiceImplTest 2/2 green ``` - [x] Grep check passes: ```bash git grep -n "org.apache.commons.io" -- shenyu-admin # Returns no hits ``` - [x] Checkstyle passes: ```bash ./mvnw -B -ntp -pl shenyu-admin checkstyle:check # clean ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
