cloudbase-ai opened a new pull request, #7889: URL: https://github.com/apache/shenyu/pull/7889
Fixes #7694. Dashboard source companion: https://github.com/apache/shenyu-dashboard/pull/727. Instance state `0` has always meant `DELETED` in the backend, but the shipped dashboard and schema comments call it unknown. Unrecognized numeric states are also reported as `DELETED` by the backend enum fallback. Keep the persisted contract (`0=DELETED`, `1=ONLINE`, `2=OFFLINE`) and the existing timeout/recovery transitions. Return `UNKNOWN` for unrecognized values without adding a new numeric state, correct fresh-schema comments, and update existing column descriptions in the 2.7.2→2.7.3 scripts. Historical stored values are not rewritten. Document that Deleted is a retained expired-instance state, rather than physical row removal. Include the generated Admin dashboard bundle from `apache/shenyu-dashboard@f239397e67c970c25a769f3b41ad3aaa7aca7a72` (source PR apache/shenyu-dashboard#727). The source baseline is `370cc40095ef4aa820449b7a9b736c7c98b6e9ab`, which is already the baseline bundled by Admin. Only the JavaScript bundle and its HTML reference change; CSS and other assets are unchanged. Build provenance and SHA-256 are recorded in `docs/instance-state-contract.md`, and the copied static files were compared byte for byte with the build output. Please merge the dashboard source companion first. Validation: - `./mvnw -pl shenyu-admin -am test -Dtest=InstanceStatusEnumTest,InstanceCheckServiceTest,InstanceInfoServiceTest,InstanceInfoMapperTest,InstanceControllerTest -Dsurefire.failIfNoSpecifiedTests=false -Drat.skip=true -Djacoco.skip=true -Dmaven.javadoc.skip=true` — 54 tests, no failures/errors; Checkstyle passed. - `./mvnw -pl shenyu-common,shenyu-admin apache-rat:check` — passed. - Dashboard `npm test` — 58 suites, 340 tests passed; focused ESLint passed; `npm run build` passed. - Regression tests distinguish deleted/unknown chart entries, pin all persisted enum codes, preserve raw unrecognized values, and exercise online→offline→deleted→online recovery. The mapper checks use H2. Native MySQL/OceanBase/PostgreSQL/openGauss/Oracle upgrade scripts and a live Admin heartbeat/dashboard end-to-end deployment were not run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
