Aias00 commented on PR #7878:
URL: https://github.com/apache/shenyu/pull/7878#issuecomment-6306493167
CI is red on the current head, and one real cause explains almost all of it.
`pr_build`, `build`, `list-contract` and `registry_dependencies` all stop in
`shenyu-admin` at `testCompile`:
```
[ERROR] RegistrationProtocolCompatibilityTest.java:[88,59] constructor
InstanceController
cannot be applied to given types;
required: InstanceInfoService, InstanceCheckService,
InstanceDiagnosticsService
found: InstanceInfoService, InstanceCheckService
```
This PR adds `InstanceDiagnosticsService` as the third `InstanceController`
constructor argument, but the pre-existing
`shenyu-admin/src/test/java/org/apache/shenyu/admin/controller/RegistrationProtocolCompatibilityTest.java`
still constructs the controller with two arguments. Adding the missing
argument (a mock/stub is enough) should clear all four jobs.
The remaining failures are unrelated infrastructure:
- `build (shenyu-integrated-test-k8s-ingress-*)` — `Could not transfer
artifact io.netty:netty-transport-native-epoll:jar:4.1.139.Final ... Connection
reset`, a Maven Central transport error. Re-running those jobs should be enough.
- `sql-matrix` failed after 3s, before any SQL ran.
Also worth noting `mergeable_state` is currently reported as
unknown/conflicting — please make sure the branch is up to date with `master`
when you push the fix, since `InstanceController` and its tests have changed
several times recently.
I have not reviewed the feature code yet; I'll do that once the build is
green.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
