konlue commented on PR #7925: URL: https://github.com/apache/shenyu/pull/7925#issuecomment-6316433753
All addressed. The blocker is gone: the `supplier` is declared right above its first use, and `checkstyle` is green across the three modules. On the non-blocking points, I went with your lean: **`null` is now treated as a clear as well.** - All three `handlerRule` implementations check `isBlank(ruleData.getHandle())` up front (including `null`) and delegate to `removeRule`. - `removeRule` in `Resilience4J` / `RateLimiter` evicts unconditionally, so deleting a rule whose handle is already `null` can no longer leave the cached handle enforcing, and the two paths can no longer disagree. That also let `Sentinel`'s clear path and the other two read the same. Plus the smaller items: - The `StringUtils` import is grouped with its siblings. - The registry reset carries an "intentional" comment. - The tests clean up their keys in `@AfterEach`. - Each handler has a `null`-handle regression test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
