Duansg opened a new pull request, #7988:
URL: https://github.com/apache/shenyu/pull/7988
## Summary
`ApolloDataService` used `LIST_STR` ("list", no leading dot) to skip list
index keys, so any data key ending with "list" was also skipped. Updates and
deletes for an appKey `whitelist`, a plugin named `blacklist`, etc. never
reached the subscribers.
Now only keys ending with `DefaultNodeConstants.POINT_LIST` (".list") are
skipped. This is also cheaper than the previous `lastIndexOf` check.
## Tests
- Added parameterized tests (ADDED / MODIFIED / DELETED) for plugin,
selector and auth keys ending with "list".
- Extended `testListKeySkipped` to cover all change types.
Make sure that:
- [x] You have read the [contribution
guidelines](https://shenyu.apache.org/community/contributor-guide).
- [x] You submit test cases (unit or integration tests) that back your
changes.
- [x] Your local test passed `./mvnw clean install
-Dmaven.javadoc.skip=true`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
