peng-yongsheng commented on issue #1032: Collector performance optimization URL: https://github.com/apache/incubator-skywalking/issues/1032#issuecomment-379450223 ### Report digest ``` metric name: /persistence, avg: 372859, rate: 0, calls: 100039, total: 37(s) metric name: /segment/parse, avg: 274427, rate: 0, calls: 56000, total: 15(s) metric name: /persistence/get, avg: 2828750, rate: 0, calls: 4464, total: 12(s) ``` Those points could be a source of performance bottlenecks. ### Performance optimization #### Segment parse - Change cache component from Guava to Caffeine, [ Caffeine's Benchmarks](https://github.com/ben-manes/caffeine/wiki/Benchmarks#read-100) ``` metric name: /persistence, avg: 194719, rate: 0, calls: 98341, total: 19(s) metric name: /segment/parse, avg: 260367, rate: 0, calls: 56624, total: 14(s) metric name: /persistence/get, avg: 1587150, rate: 0, calls: 4032, total: 6(s) ``` - Span listeners create ``` metric name: /segment/parse/createSpanListeners, avg: 26518, rate: 0, calls: 98462, total: 2(s) metric name: /segment/parse/createSpanListeners/serviceReferenceMetricSpanListener, avg: 20038, rate: 0, calls: 14066, total: 281(ms) metric name: /segment/parse/createSpanListeners/applicationComponentSpanListener, avg: 1550, rate: 0, calls: 14066, total: 21(ms) metric name: /segment/parse/createSpanListeners/applicationMappingSpanListener, avg: 17050, rate: 0, calls: 14066, total: 239(ms) metric name: /segment/parse/createSpanListeners/instanceMappingSpanListener, avg: 15595, rate: 0, calls: 14066, total: 219(ms) metric name: /segment/parse/createSpanListeners/globalTraceSpanListener, avg: 16881, rate: 0, calls: 14066, total: 237(ms) metric name: /segment/parse/createSpanListeners/segmentDurationSpanListener, avg: 16651, rate: 0, calls: 14066, total: 234(ms) ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
