wu-sheng commented on issue #1069: Replaced ObjectUtils for java.utils.Objects 
methods
URL: 
https://github.com/apache/incubator-skywalking/pull/1069#issuecomment-380484104
 
 
   @nikitap492  Thanks. That is better to understand your pr. Then I will focus 
on codes only for this pr.
   
   At least, we need to make sure there is no bug caused by this. Right? :) 
   
   > Could you look at InstanceCacheGuavaService, for example. The methods 
getApplicationId , getInstanceIdByAgentUUID and getInstanceIdByAddressId had 
very similar code and few difference. I tried to generalize it.
   
   For `InstanceCacheService`, you can try to refactor it. But don't try to 
merge these two method signatures. These two methods are about two different 
business scenario. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to