wu-sheng opened a new pull request #1081: Refactor ServerTypeDefine and 
ComponentsDefine to be more extendable
URL: https://github.com/apache/incubator-skywalking/pull/1081
 
 
   Please answer these questions before submitting pull request
   
   - Why submit this pull request?
   - [ ] Bug fix
   - [x] New feature provided
   - [ ] Improve performance
   
   - Related issues
   #1078
   
   ___
   ### New feature or improvement
   - Describe the details and related test reports.
   
   I refactor the ServerTypeDefine and ComponentsDefine to 
`component-libraries.yml` file with two sections in it:
   1. Component Section
   
![image](https://user-images.githubusercontent.com/5441976/38796585-6e5d9382-418e-11e8-8af2-8a71f02cde69.png)
   
   2. Component Server Mapping Section
   
![image](https://user-images.githubusercontent.com/5441976/38796589-717d3e3c-418e-11e8-8004-dd168acaa813.png)
   
   Id should be unique, every other language agent or SDK should submit your 
component to here, to change these manually. Of source, we only accept open 
source frameworks or online services.
   
   I add a service `IComponentLibraryCatalogService` in configuration module 
provider, to read component id, component name and component server id.
   
   Other thing in this proposal is a bug. When component name should be used if 
component id is 0(means null).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to