wu-sheng closed pull request #1121: Fixed windows startup.bat script error URL: https://github.com/apache/incubator-skywalking/pull/1121
This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/apm-dist/bin/collectorService.bat b/apm-dist/bin/collectorService.bat index 00bad07f9..b16ee1b1a 100644 --- a/apm-dist/bin/collectorService.bat +++ b/apm-dist/bin/collectorService.bat @@ -25,7 +25,7 @@ set CLASSPATH=%COLLECTOR_HOME%\config;.; set CLASSPATH=%COLLECTOR_HOME%\collector-libs\*;%CLASSPATH% if defined JAVA_HOME ( - set _EXECJAVA="%JAVA_HOME:"=%"\bin\java + set _EXECJAVA="%JAVA_HOME%\bin\java" ) if not defined JAVA_HOME ( diff --git a/apm-dist/bin/webappService.bat b/apm-dist/bin/webappService.bat index 22dd6e917..a7aad00d3 100644 --- a/apm-dist/bin/webappService.bat +++ b/apm-dist/bin/webappService.bat @@ -29,7 +29,7 @@ if exist "%WEBAPP_LOG_DIR%" ( set LOG_FILE_LOCATION=%WEBAPP_LOG_DIR%\webapp.log if defined JAVA_HOME ( - set _EXECJAVA="%JAVA_HOME:"=%"\bin\java + set _EXECJAVA="%JAVA_HOME%\bin\java" ) if not defined JAVA_HOME ( ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services