wu-sheng commented on a change in pull request #1213: provides a
optional-plugin for tracking ignores enhancement(#1203)
URL:
https://github.com/apache/incubator-skywalking/pull/1213#discussion_r187820927
##########
File path:
apm-sniffer/optional-plugins/trace-ignore-plugin/src/main/java/org/apache/skywalking/apm/plugin/trace/ignore/matcher/SpringAntPathMatcher.java
##########
@@ -0,0 +1,14 @@
+package org.apache.skywalking.apm.plugin.trace.ignore.matcher;
+
+import org.springframework.util.AntPathMatcher;
+import org.springframework.util.PathMatcher;
+
+public class SpringAntPathMatcher implements TracePathMatcher {
+
+ private PathMatcher pathMatcher = new AntPathMatcher();
Review comment:
If you are using the Spring matcher, then the plugin has to include the
Spring jar into it. And you put `<artifactId>spring-core</artifactId>` provided
in your pom. So who can make the spring core jar in the agent class loader?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
