wu-sheng commented on a change in pull request #1213: provides a 
optional-plugin for tracking ignores enhancement(#1203)
URL: 
https://github.com/apache/incubator-skywalking/pull/1213#discussion_r187881241
 
 

 ##########
 File path: apm-sniffer/optional-plugins/trace-ignore-plugin/README.md
 ##########
 @@ -0,0 +1,2 @@
+###How to use trace ignore plugin
+Please copy the apm-trace-ignore-plugin-x.jar to `agent/plugins`, this plugin 
support reading config from environment variables(The env key must start with 
`skywalking.`, the reuslt should be as same as in 
`apm-trace-ignore-plugin.config`), or you can copy the 
`apm-trace-ignore-plugin.config` to `agent/config` then you'll set you need 
ignore paths in `apm-trace-ignore-plugin.config`
 
 Review comment:
   See here: 
https://github.com/SevenPointOld/incubator-skywalking/blob/18790363b3ba50738ea3e577b63506fce16a4e77/apm-sniffer/optional-plugins/trace-ignore-plugin/README.md
   
   Your markdown don't look good. Please provide sections about two usages.
   ```
   # title
   Abstrct
   
   ## Usage
   1. ...... use config file.....
   2. ...... through env, and examples
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to