SevenPointOld commented on a change in pull request #1213: provides a 
optional-plugin for tracking ignores enhancement(#1203)
URL: 
https://github.com/apache/incubator-skywalking/pull/1213#discussion_r187901335
 
 

 ##########
 File path: apm-sniffer/optional-plugins/pom.xml
 ##########
 @@ -31,11 +31,15 @@
         <shade.net.bytebuddy.source>net.bytebuddy</shade.net.bytebuddy.source>
         
<shade.net.bytebuddy.target>${shade.package}.${shade.net.bytebuddy.source}</shade.net.bytebuddy.target>
 
-        
<plugin.dest.dir>${project.build.directory}/../../../../skywalking-agent/optional-plugins</plugin.dest.dir>
+        <sdk.plugin.related.dir />
 
 Review comment:
   I add  `<sdk.plugin.related.dir />` follow `apm-sdk-plugin/pom`  
   
![image](https://user-images.githubusercontent.com/12181207/39991540-7ab090c4-57a2-11e8-9f71-74d6f527b550.png)
   It's just a statement, the sub pom if need this properties should override 
it,  then act on `${agent.package.dest.dir}`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to