ascrutae commented on a change in pull request #1210: Add sofa rpc plugin
integration
URL:
https://github.com/apache/incubator-skywalking/pull/1210#discussion_r187962693
##########
File path:
apm-protocol/apm-network/src/main/java/org/apache/skywalking/apm/network/trace/component/ComponentsDefine.java
##########
@@ -84,6 +84,8 @@
public static final OfficialComponent HYSTRIX = new OfficialComponent(29,
"Hystrix");
+ public static final OfficialComponent SOFARPC = new OfficialComponent(30,
"SOFARPC");
Review comment:
the value that it define in `component-libraries.yml`file isn't equals the
value define in `ComponentsDefine.java` file
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
