wu-sheng commented on a change in pull request #1266: Change component definitions URL: https://github.com/apache/incubator-skywalking/pull/1266#discussion_r190928095
########## File path: apm-collector/apm-collector-boot/src/main/resources/component-libraries.yml ########## @@ -123,7 +123,36 @@ Jedis: SQLite: id: 31 languages: Java,C# - +h2-jdbc-driver: + id: 32 + languages: Java +mysql-connector-java: + id: 33 + languages: Java +Spymemcached: + id: 35 + languages: Java +Xmemcached: + id: 36 + languages: Java +postgresql-jdbc-driver: + id: 37 + languages: Java +rocketMQ-producer-client: Review comment: you should name as consumer and producer. No client needed. They are all clients for kafka server. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
