wu-sheng commented on a change in pull request #1347: support shardingjdbc
database storage feature
URL:
https://github.com/apache/incubator-skywalking/pull/1347#discussion_r194655271
##########
File path: apm-collector/apm-collector-component/client-component/pom.xml
##########
@@ -101,5 +101,15 @@
</exclusion>
</exclusions>
</dependency>
+ <dependency>
+ <groupId>io.shardingjdbc</groupId>
+ <artifactId>sharding-jdbc-core</artifactId>
+ <version>2.0.3</version>
+ </dependency>
+ <dependency>
+ <groupId>commons-dbcp</groupId>
+ <artifactId>commons-dbcp</artifactId>
+ <version>1.4</version>
+ </dependency>
Review comment:
dependency and version should be defined in collector root pom.xml
See here:
https://github.com/apache/incubator-skywalking/blob/master/apm-collector/pom.xml#L97-L240
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
