wu-sheng closed pull request #1582: Moved hardcoded dependency versions to
properties tag in pom.xml
URL: https://github.com/apache/incubator-skywalking/pull/1582
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/pom.xml b/pom.xml
index a66b4be12..25c256adb 100644
--- a/pom.xml
+++ b/pom.xml
@@ -111,21 +111,46 @@
<compiler.version>1.8</compiler.version>
<scala.compiler.version>2.11.7</scala.compiler.version>
<powermock.version>1.6.4</powermock.version>
- <docker.plugin.version>0.4.13</docker.plugin.version>
<checkstyle.version>6.18</checkstyle.version>
+ <junit.version>4.12</junit.version>
+ <mockito-all.version>1.10.19</mockito-all.version>
+
+ <!-- Plugin versions -->
+ <docker.plugin.version>0.4.13</docker.plugin.version>
+ <takari-maven-plugin.version>0.6.1</takari-maven-plugin.version>
+ <exec-maven-plugin.version>1.6.0</exec-maven-plugin.version>
+ <maven-antrun-plugin.version>1.8</maven-antrun-plugin.version>
+ <maven-deploy-plugin.version>2.8.2</maven-deploy-plugin.version>
+ <maven-assembly-plugin.version>3.1.0</maven-assembly-plugin.version>
+ <maven-failsafe-plugin.version>2.22.0</maven-failsafe-plugin.version>
+ <maven-surefire-plugin.version>2.22.0</maven-surefire-plugin.version>
+ <maven-jar-plugin.version>3.1.0</maven-jar-plugin.version>
+ <maven-shade-plugin.version>3.1.1</maven-shade-plugin.version>
+ <maven-enforcer-plugin.version>3.0.0-M2</maven-enforcer-plugin.version>
+ <apache-rat-plugin.version>0.12</apache-rat-plugin.version>
+ <maven-compiler-plugin.version>3.8.0</maven-compiler-plugin.version>
+ <maven-resource-plugin.version>3.1.0</maven-resource-plugin.version>
+ <maven-source-plugin.version>3.0.1</maven-source-plugin.version>
+ <versions-maven-plugin.version>2.5</versions-maven-plugin.version>
+ <coveralls-maven-plugin.version>4.3.0</coveralls-maven-plugin.version>
+ <jacoco-maven-plugin.version>0.8.1</jacoco-maven-plugin.version>
+
<maven-checkstyle-plugin.version>3.0.0</maven-checkstyle-plugin.version>
+
+
+
</properties>
<dependencies>
<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
- <version>4.12</version>
+ <version>${junit.version}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.mockito</groupId>
<artifactId>mockito-all</artifactId>
- <version>1.10.19</version>
+ <version>${mockito-all.version}</version>
<scope>test</scope>
</dependency>
<dependency>
@@ -149,47 +174,47 @@
<plugin>
<groupId>io.takari</groupId>
<artifactId>maven</artifactId>
- <version>0.6.1</version>
+ <version>${takari-maven-plugin.version}</version>
</plugin>
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>exec-maven-plugin</artifactId>
- <version>1.6.0</version>
+ <version>${exec-maven-plugin.version}</version>
</plugin>
<plugin>
<artifactId>maven-antrun-plugin</artifactId>
- <version>1.8</version>
+ <version>${maven-antrun-plugin.version}</version>
</plugin>
<plugin>
<artifactId>maven-deploy-plugin</artifactId>
- <version>2.8.2</version>
+ <version>${maven-deploy-plugin.version}</version>
</plugin>
<plugin>
<artifactId>maven-assembly-plugin</artifactId>
- <version>3.1.0</version>
+ <version>${maven-assembly-plugin.version}</version>
</plugin>
<plugin>
<artifactId>maven-failsafe-plugin</artifactId>
- <version>2.22.0</version>
+ <version>${maven-failsafe-plugin.version}</version>
</plugin>
<plugin>
<artifactId>maven-surefire-plugin</artifactId>
- <version>2.22.0</version>
+ <version>${maven-surefire-plugin.version}</version>
</plugin>
<plugin>
<artifactId>maven-jar-plugin</artifactId>
- <version>3.1.0</version>
+ <version>${maven-jar-plugin.version}</version>
</plugin>
<plugin>
<artifactId>maven-shade-plugin</artifactId>
- <version>3.1.1</version>
+ <version>${maven-shade-plugin.version}</version>
</plugin>
</plugins>
</pluginManagement>
<plugins>
<plugin>
<artifactId>maven-enforcer-plugin</artifactId>
- <version>3.0.0-M2</version>
+ <version>${maven-enforcer-plugin.version}</version>
<executions>
<execution>
<id>enforce-java</id>
@@ -210,7 +235,7 @@
<plugin>
<groupId>org.apache.rat</groupId>
<artifactId>apache-rat-plugin</artifactId>
- <version>0.12</version>
+ <version>${apache-rat-plugin.version}</version>
<configuration>
<excludes>
<exclude>**/target/**</exclude>
@@ -282,7 +307,7 @@
</plugin>
<plugin>
<artifactId>maven-compiler-plugin</artifactId>
- <version>3.8.0</version>
+ <version>${maven-compiler-plugin.version}</version>
<configuration>
<source>${compiler.version}</source>
<target>${compiler.version}</target>
@@ -291,7 +316,7 @@
</plugin>
<plugin>
<artifactId>maven-resources-plugin</artifactId>
- <version>3.1.0</version>
+ <version>${maven-resource-plugin.version}</version>
<configuration>
<encoding>${project.build.sourceEncoding}</encoding>
</configuration>
@@ -307,7 +332,7 @@
<plugin>
<!-- 源码插件 -->
<artifactId>maven-source-plugin</artifactId>
- <version>3.0.1</version>
+ <version>${maven-source-plugin.version}</version>
<!-- 发布时自动将源码同时发布的配置 -->
<executions>
<execution>
@@ -322,12 +347,12 @@
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>versions-maven-plugin</artifactId>
- <version>2.5</version>
+ <version>${versions-maven-plugin.version}</version>
</plugin>
<plugin>
<groupId>org.eluder.coveralls</groupId>
<artifactId>coveralls-maven-plugin</artifactId>
- <version>4.3.0</version>
+ <version>${coveralls-maven-plugin.version}</version>
<configuration>
<sourceDirectories>
<sourceDirectory>${project.build.sourceDirectory}</sourceDirectory>
@@ -338,7 +363,7 @@
<plugin>
<groupId>org.jacoco</groupId>
<artifactId>jacoco-maven-plugin</artifactId>
- <version>0.8.1</version>
+ <version>${jacoco-maven-plugin.version}</version>
<configuration>
<excludes>
<exclude>*MethodAccess</exclude>
@@ -355,7 +380,7 @@
</plugin>
<plugin>
<artifactId>maven-checkstyle-plugin</artifactId>
- <version>3.0.0</version>
+ <version>${maven-checkstyle-plugin.version}</version>
<dependencies>
<dependency>
<groupId>org.apache.skywalking</groupId>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
