wu-sheng commented on issue #1584: add the function of the specified agent config URL: https://github.com/apache/incubator-skywalking/pull/1584#issuecomment-415629796 First of all, in the theory, I am OK with this PR. You need to fix the following things. 1. No English document. `docs/en/Specified-agent-config.md` is empty. Apache requires English document as default and only official document. 1. I have concern about you are using `javaagent` argument(String) as the path only. This blocks other potential usage of this arguments. I want to discuss about, whether we could use `-D` or System.env to set the config file, instead of change this argument? The reason I proposed this is that, a) In traditional ways, SkyWalking already used these. b) These are easier to understand and fit Cloud Native (Docker based) I need sync the info with you that, I am going to do RC release at Monday, I need to freeze codes before that and do several release tests. So if you didn't have time to adjust, I will mark this as GA feature, which will be released soon too. (3-4 weeks later from now)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
