IanCao commented on a change in pull request #1584: add the function of the
specified agent config
URL:
https://github.com/apache/incubator-skywalking/pull/1584#discussion_r212784494
##########
File path:
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/conf/SnifferConfigInitializer.java
##########
@@ -41,12 +41,14 @@
*/
public class SnifferConfigInitializer {
private static final ILog logger =
LogManager.getLogger(SnifferConfigInitializer.class);
- private static String CONFIG_FILE_NAME = "/config/agent.config";
+ private static String SPECIFIED_CONFIG_PATH = "sw.specified_config_path";
Review comment:
The reason i use sw as prefix is that #ENV_KEY_PREFIX is use to override the
properties in agent .config...so i just wonder whether it will make some
trouble when i use #ENV_KEY_PREFIX as prefix or not...if you think the prefix
should be same, i would like to make it consistent..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
