chickenlj commented on issue #1769: It does not support dubbo v2.6.2+？ URL: https://github.com/apache/incubator-skywalking/issues/1769#issuecomment-432093152 > > A method level annotation to enable auto-injection or not. > > @chickenlj I hope the default is not :) SkyWalking will add this method to all enhanced classes, we can't add an annotation belongs to Dubbo only, may trigger ClassNotFound in other scenarios. Set the default value to not would bring lots of changes to Dubbo, many methods would need to add an annotation and enable injection. Can't SkyWalking just add an annotation when instrumenting Dubbo? Anyway, I think Dubbo need an annotation to flexibly control the injection action. > Or, when could not find the inject way, just ignore. The auto set should not be active always from my perspective. Sounds reasonable, I will consider the possibility of ignoring it when fails.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
