ni-ze commented on a change in pull request #1875: Correct overriding parent
class methods,when method parameters have annotations.More details to see the
issue #1740
URL:
https://github.com/apache/incubator-skywalking/pull/1875#discussion_r230549215
##########
File path:
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/plugin/interceptor/enhance/ClassEnhancePluginDefine.java
##########
@@ -186,12 +189,12 @@
/**
* Enhance a class to intercept class static methods.
*
- * @param enhanceOriginClassName target class name
+ * @param typeDescription The description of the type currently being
instrumented.
* @param newClassBuilder byte-buddy's builder to manipulate class
bytecode.
* @return new byte-buddy's builder for further manipulation.
*/
- private DynamicType.Builder<?> enhanceClass(String enhanceOriginClassName,
- DynamicType.Builder<?> newClassBuilder, ClassLoader classLoader)
throws PluginException {
+ private DynamicType.Builder<?> enhanceClass(TypeDescription
typeDescription,
Review comment:
It does confuse me. But it right on my notebook. I will check it out.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
