wu-sheng commented on a change in pull request #1957: feat:Active System.env
Config In Both Collector And agent.config.
URL:
https://github.com/apache/incubator-skywalking/pull/1957#discussion_r236045290
##########
File path:
apm-commons/apm-util/src/main/java/org/apache/skywalking/apm/util/PropertyPlaceholderHelper.java
##########
@@ -16,27 +16,24 @@
*
*/
-package org.apache.skywalking.oap.server.library.util;
+package org.apache.skywalking.apm.util;
-import com.google.common.base.Strings;
import java.util.HashMap;
import java.util.HashSet;
import java.util.Map;
import java.util.Properties;
import java.util.Set;
-import org.apache.logging.log4j.core.util.Assert;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
+import java.util.logging.Logger;
/**
* Utility class for working with Strings that have placeholder values in
them. A placeholder takes the form {@code
* ${name}}. Using {@code PropertyPlaceholderHelper} these placeholders can be
substituted for user-supplied values. <p>
* Values for substitution can be supplied using a {@link Properties} instance
or using a {@link PlaceholderResolver}.
*/
public class PropertyPlaceholderHelper {
- private static final Logger logger =
LoggerFactory.getLogger(PropertyPlaceholderHelper.class);
+ private static final Logger logger =
Logger.getLogger(PropertyPlaceholderHelper.class.getName());
Review comment:
Maybe a light bridge mechanism? Make `PropertyPlaceholderHelper` abstract,
and ask each side implements a `log(String` method?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
