zhaoyuguang commented on a change in pull request #2152: Support lettuce plugin
URL:
https://github.com/apache/incubator-skywalking/pull/2152#discussion_r250856995
##########
File path:
apm-sniffer/optional-plugins/lettuce-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/lettuce/v5/AsyncCommandMethodInterceptor.java
##########
@@ -37,7 +38,8 @@
@SuppressWarnings("unchecked")
public void beforeMethod(EnhancedInstance objInst, Method method, Object[]
allArguments, Class<?>[] argumentsTypes,
MethodInterceptResult result) throws Throwable {
- AbstractSpan span =
ContextManager.createLocalSpan("AsyncCommand/onComplete");
+ AsyncCommand asyncCommand = (AsyncCommand) objInst;
+ AbstractSpan span = ContextManager.createLocalSpan("AsyncCommand/" +
asyncCommand.getType().name() + "/onComplete");
Review comment:
I am modifying it again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
