hanahmily commented on pull request #12:
URL: https://github.com/apache/skywalking-swck/pull/12#issuecomment-733536395


   >
   > >  I think we need to fix this.
   
   Yep, will update the site ASAP.
   
   > we need the docker file in the release binary tar ball.
   
   
   sure, release binary's original duty is to build a convenient image for end
   users. Actually, swck's document/guides is based on this image.
    If it doesn't exist, the end-user can't follow these steps indicated on
   that.
   
   吴晟 Wu Sheng <notificati...@github.com> 于2020年11月25日周三 下午3:42写道:
   
   > *@wu-sheng* commented on this pull request.
   > ------------------------------
   >
   > In doc/custom-metrics-adapter.md
   > <https://github.com/apache/skywalking-swck/pull/12#discussion_r530162327>:
   >
   > > + * `service` varies in different scopes. If the scope is `Service`, 
`ServiceInstance` and `Endpoint`, the `service` represents
   > +    `serviceName`, `serviceInstanceName` and `endpointName` respectively.
   >
   > We release a binary package actually,
   > https://dist.apache.org/repos/dist/release/skywalking/swck/0.1.0/. But
   > it's used to build the release image.
   >
   > This is strange, we have binary on the apache mirror system, but no one is
   > able to download it, and no one knows it exists. I think we need to fix
   > this.
   >
   > Image is another topic, if you want to release that, we need the docker
   > file in the release binary tar ball.
   >
   > —
   > You are receiving this because you authored the thread.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/skywalking-swck/pull/12#discussion_r530162327>,
   > or unsubscribe
   > 
<https://github.com/notifications/unsubscribe-auth/AAO6UWK7PF5Z5TLL2FVD52TSRSYNDANCNFSM4T6IBBFA>
   > .
   >
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to