[GitHub] [skywalking] starboyate commented on issue #5925: Optimize the addition of TraceSegmentRef

[GitBox]

starboyate commented on issue #5925:
URL: https://github.com/apache/skywalking/issues/5925#issuecomment-735646458


   
![image](https://user-images.githubusercontent.com/40192576/100587337-6372a480-332b-11eb-95b1-4a4558c27ed3.png)
   
![image](https://user-images.githubusercontent.com/40192576/100587353-67062b80-332b-11eb-96fb-8562f72c1504.png)
   I just think it can save the extra creation of TraceSegmentRef object, 
because the created TraceSegmentRef object may already exist. If the 
corresponding TraceSegmentRef object already exists, there is no need to create 
it and then judge whether it exists, which will result in the creation of 
TraceSegmentRef It doesn't work because it already exists in the LinkedList


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org