wu-sheng commented on a change in pull request #5914:
URL: https://github.com/apache/skywalking/pull/5914#discussion_r536556810



##########
File path: docs/en/setup/service-agent/java-agent/README.md
##########
@@ -175,6 +175,7 @@ Now, we have the following known optional plugins.
 * [Plugin of Kotlin 
coroutine](agent-optional-plugins/Kotlin-Coroutine-plugin.md) provides the 
tracing across coroutines automatically. As it will add local spans to all 
across routines scenarios, Please assess the performance impact.
 * Plugin of quartz-scheduler-2.x in the optional plugin folder. The reason for 
being an optional plugin is, many task scheduling systems are based on 
quartz-scheduler, this will cause duplicate tracing and link different 
sub-tasks as they share the same quartz level trigger, such as ElasticJob.
 * Plugin of spring-webflux-5.x in the optional plugin folder. Please only 
activate this plugin when you use webflux alone as a web container. If you are 
using SpringMVC 5 or Spring Gateway, you don't need this plugin.
+* [Plugin of logger(logback, log4j, 
log4j2)](agent-optional-plugins/Logger-plugin.md) in the optional plugin 
folder. For the performance perspective, please only activate it when you need 
add log(from logback,log4j or log4j2) to span log event.

Review comment:
       ```suggestion
   * [Plugin of logger(logback, log4j, 
log4j2)](agent-optional-plugins/Logger-plugin.md) in the optional plugin 
folder. For the performance perspective, please only activate it when you need 
to add logs(from logback,log4j or log4j2) to the span log event. **Collecting 
too many logs would impact the performance of the agent and your service 
seriously. Recommend to collect necessary logs only.**
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to