ZS-Oliver commented on a change in pull request #5989:
URL: https://github.com/apache/skywalking/pull/5989#discussion_r542101042
##########
File path:
apm-sniffer/apm-sdk-plugin/thrift-plugin/src/main/java/org/apache/skywalking/apm/plugin/thrift/wrapper/ServerInProtocolWrapper.java
##########
@@ -81,6 +90,20 @@ public TField readFieldBegin() throws TException {
}
return readFieldBegin();
}
+ if (field.type == TType.STOP && !HAVE_CREATED.get()) {
Review comment:
I saw ServerInProtocolWrapper was initialized in
TServerInterceptor.onConstruct.
The method onConstruct was called when an intercept construction method is
called.
I use ThreadLocal to do the isolation, because I think this behavior will
only be invoked once during the enhancement.
Are there any better way to implement this ?
##########
File path:
apm-sniffer/apm-sdk-plugin/thrift-plugin/src/main/java/org/apache/skywalking/apm/plugin/thrift/wrapper/ServerInProtocolWrapper.java
##########
@@ -57,10 +64,11 @@ public void initial(AbstractContext context) {
@Override
public TField readFieldBegin() throws TException {
final TField field = super.readFieldBegin();
+ Map<String, String> header = new HashMap<>(1);
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
