vcjmhg commented on pull request #6003:
URL: https://github.com/apache/skywalking/pull/6003#issuecomment-744387225
> I hope so
@kezhenxu94 ,because `scenarios` is not a maven project, there are two ways
for checking the codes with the Chekcstyle plugin:
1. add `<sourceDirectory>scenario-name<sourceDirectory>` into
`test/plugin/pom.xml`. Just like this:
```xml
<sourceDirectories>
<sourceDirectory>${project.build.sourceDirectory}</sourceDirectory>
<sourceDirectory>${project.build.testSourceDirectory}</sourceDirectory>
<sourceDirectory>scenarios/activemq-scenario</sourceDirectory>
</sourceDirectories>
```
Meanwhile, in order to make new test-case projects will be checked with the
Checkestyle plugin, I will modify the `generator.sh`. And ensure that when
creating a new project through the `generator.sh`, a tag like
`<sourceDirectory>new-scenario-name<sourceDirectory>` will be added in
`test/plugin/pom.xml`.
2. make `scenarios` to be a maven project and make all projects in its
folder become its subprojects
like method one, I also can modify the `generator.sh`.
Which method would be better?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
