kezhenxu94 edited a comment on pull request #172: URL: https://github.com/apache/skywalking-website/pull/172#issuecomment-747859972
@lujiajing1126 > IMHO, the `cleanup` action should always appear together with the `setup` action since `cleanup` should be done if the corresponding setup succeeds regardless of other actions and setup. The whole procedure is similar to a stack. Definitely `cleanup` should ALWAYS appear together with `setup`, please read this in the doc: "this command is a wrapper that glues all the following commands, which can be executed separately, for example, to debug the case" Let me explain, when you run the wrapper command, it ensures the `cleanup` step to be executed no mater what other commands exit codes, but when you run the steps one by one manually (when debugging), you don't want the cluster to be destroyed after tests, right? You want to keep the scene to check what's wrong inside the cluster, after you find out the reason, you will destroy the cluster via `cleanup` command, hence the `cleanup` step needs the same options as the `setup` because at this time, there is not context what had been set up if you run `cleanup` separately, right? I'll update the part to indicate that `cleanup` will always be executed when running `e2e run` as a whole ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
