[GitHub] [skywalking-cli] fgksgf commented on a change in pull request #82: chore: reorganize the project layout and add an example of .skywalking.yaml

Fri, 18 Dec 2020 03:58:49 -0800 


fgksgf commented on a change in pull request #82:
URL: https://github.com/apache/skywalking-cli/pull/82#discussion_r545786348



##########
File path: pkg/heatmap/axes/label.go
##########
@@ -108,7 +108,7 @@ func xLabels(yEnd image.Point, graphWidth int, stringLabels 
[]string, cellWidth
 
 // paddedLabelLength calculates the length of the padded label and
 // the column index corresponding to the label.
-// For example, the longest label's length is 5, like '12:34', and the cell's 
width is 3.
+// For examples, the longest label's length is 5, like '12:34', and the cell's 
width is 3.

Review comment:
       I don't think `for examples` is correct.
   
![image](https://user-images.githubusercontent.com/26627380/102612188-3fa4c080-416b-11eb-8359-d2c8c14f987f.png)
   
![image](https://user-images.githubusercontent.com/26627380/102612255-59460800-416b-11eb-9afe-9d7c71ab4dce.png)
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to