wu-sheng commented on a change in pull request #6003:
URL: https://github.com/apache/skywalking/pull/6003#discussion_r546244830
##########
File path: test/plugin/pom.xml
##########
@@ -99,6 +103,151 @@
<encoding>${project.build.sourceEncoding}</encoding>
</configuration>
</plugin>
+ <plugin>
+ <artifactId>maven-checkstyle-plugin</artifactId>
+ <version>${maven-checkstyle-plugin.version}</version>
+ <configuration>
+
<configLocation>${maven.multiModuleProjectDirectory}/apm-checkstyle/checkStyle.xml</configLocation>
+
<headerLocation>${maven.multiModuleProjectDirectory}/apm-checkstyle/CHECKSTYLE_HEAD</headerLocation>
+ <encoding>UTF-8</encoding>
+ <consoleOutput>true</consoleOutput>
+
<includeTestSourceDirectory>true</includeTestSourceDirectory>
+
<failOnViolation>${checkstyle.fails.on.error}</failOnViolation>
+ <sourceDirectories>
+
<sourceDirectory>${project.build.sourceDirectory}</sourceDirectory>
Review comment:
Why limit it to new only? Why don't we do that before running the tests
and check the code style first?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
