vcjmhg commented on a change in pull request #6003:
URL: https://github.com/apache/skywalking/pull/6003#discussion_r546332154
##########
File path: test/plugin/pom.xml
##########
@@ -99,6 +103,151 @@
<encoding>${project.build.sourceEncoding}</encoding>
</configuration>
</plugin>
+ <plugin>
+ <artifactId>maven-checkstyle-plugin</artifactId>
+ <version>${maven-checkstyle-plugin.version}</version>
+ <configuration>
+
<configLocation>${maven.multiModuleProjectDirectory}/apm-checkstyle/checkStyle.xml</configLocation>
+
<headerLocation>${maven.multiModuleProjectDirectory}/apm-checkstyle/CHECKSTYLE_HEAD</headerLocation>
+ <encoding>UTF-8</encoding>
+ <consoleOutput>true</consoleOutput>
+
<includeTestSourceDirectory>true</includeTestSourceDirectory>
+
<failOnViolation>${checkstyle.fails.on.error}</failOnViolation>
+ <sourceDirectories>
+
<sourceDirectory>${project.build.sourceDirectory}</sourceDirectory>
Review comment:
> The changed pom.xml wouldn't be submitted or merged. It is updated in
the CI process only.
Add the scenario name into `pom.xml` before run, and delete the added
content after execution. Is it like this?
> Could you be more clear about what does this mean? Why does code style
relate to JDK version?
When I add `
<sourceDirectory>scenarios/jdk14-with-gson-scenario</sourceDirectory>` into
`plugin/pom.xml`, We can see the following verification results：
`Failed to execute goal
org.apache.maven.plugins:maven-checkstyle-plugin:3.1.0:check (validate) on
project apache-skywalking-test-plugin: Failed during checkstyle configuration
`
So, I guess the reason may be caused by different jdk versions and I handle
it separately. If my understanding is wrong or you have a better solution
please let me know
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
