EvanLjp commented on a change in pull request #10:
URL:
https://github.com/apache/skywalking-satellite/pull/10#discussion_r548944865
##########
File path: internal/satellite/module/sender/sender.go
##########
@@ -130,12 +131,12 @@ func (s *Sender) Shutdown() {
func (s *Sender) consume(batch *buffer.BatchBuffer) {
log.Logger.Infof("sender module of %s namespace is flushing a new batch
buffer."+
" the start offset is %s, and the size is %d",
s.config.NamespaceName, batch.Last(), batch.Len())
- var events = make(map[event.Type]event.BatchEvents)
+ var events = make(map[protocol.EventType]event.BatchEvents)
for i := 0; i < batch.Len(); i++ {
eventContext := batch.Buf()[i]
for _, e := range eventContext.Context {
- if e.IsRemote() {
- events[e.Type()] = append(events[e.Type()], e)
+ if e.Remote {
Review comment:
use proto
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
