wu-sheng commented on a change in pull request #6066:
URL: https://github.com/apache/skywalking/pull/6066#discussion_r548963510
##########
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/manual/endpoint/EndpointTraffic.java
##########
@@ -39,7 +40,7 @@
builder = EndpointTraffic.Builder.class, processor =
MetricsStreamProcessor.class)
@MetricsExtension(supportDownSampling = false, supportUpdate = false)
@EqualsAndHashCode
-public class EndpointTraffic extends Metrics {
+public class EndpointTraffic extends Metrics implements Traffic {
Review comment:
If you says this implementing `Traffic#name`, the name is exactly the
`id`(as nodeType related to name logically). What is the point of doing this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
