kezhenxu94 edited a comment on pull request #12:
URL: https://github.com/apache/skywalking-eyes/pull/12#issuecomment-751430880


   > As a monorepo, you have to make sure all codes are ready
   
   1. I don't think so, we can release only parts of the codes in this repo. 
The parts we actually released will go into https://dist.apache.org
   
   > Maybe we need two milestones, one for `license-eye` and the other for 
`quality-eye` ?
   
   2. I consider this is a good idea (`license-eye-0.1.0` and 
`quality-eye-0.1.0`), this allows us to track the corresponding issues/PRs in 
each tool.
   
   > 0.1.0-licence-eye and 0.1.0-quality-eye would be very confused as both of 
them includes uncompleted codes if I check out the tag.
   
   3. Because of (1), we will use another release method, that is, check out a 
new branch for releasing (only pick out what will be really released, for 
example, `license-eye` directory), and tag upon that branch (e.g. tag name == 
`license-eye-0.1.0`), when voting, we use the tag and the commit id of that 
branch, there is no different steps as what we've been doing already. And there 
is no "uncompleted codes if you check out the tag".
   
   As this is a brand new repo and the 2 tools (license-eye and quality-eye) 
are at their early development, IMO (3) allows us to move fast and won't block 
each other in terms of codes consistency or readiness.
   
   @wu-sheng any further concern?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to