hanahmily commented on a change in pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#discussion_r549249655
##########
File path:
oap-server/server-bootstrap/src/main/resources/otel-oc-rules/istio-controlplane.yaml
##########
@@ -28,7 +28,7 @@
# "-P6H3M" -- parses as "-6 hours and -3 minutes"
# "-P-6H+3M" -- parses as "+6 hours and -3 minutes"
# </pre>
-expSuffix: tag({tags -> tags.cluster = 'istio-ctrl::' +
tags.cluster}).service(['cluster', 'app'])
Review comment:
This rule file intends to ingest metrics from different Kubernetes
clusters, not identify control plane and data plane. There might be more than
one cluster when two different OT collectors transfer metrics to the OAP
cluster.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
