vcjmhg commented on pull request #6003: URL: https://github.com/apache/skywalking/pull/6003#issuecomment-751955624
@wu-sheng @kezhenxu94 Sorry, some time ago, the progress was a bit slow because I was preparing to the Dissertation Proposal. Let me briefly talk about a basic idea to solve this problem at present. **Currently**, it still add `<sourceDirectory>scenarios/$scenario_name<\/sourceDirectory>` into plugin/pom.xml that make the code can be checked by the `checkstyle-plugin`. **The problems we encountered before**: >jdk14-with-gson-scenario cannot be checked by adding its name in plugin/pom.xml because of different JDK versions. I fix the problem by [Upgrading Checkstyle at Runtime](http://maven.apache.org/plugins/maven-checkstyle-plugin/examples/upgrading-checkstyle.html). And Because `maven-checkstyle-plugin 3.1.10` not support `checkstyle 8.38`, I update it to `maven-checkstyle-plugin 3.1.11`. **The only problem at the moment is how to format `retransform-class-tomcat-scenario`:** I have tried several times including modifying the package name from `test.org.apache.skywalking.apm.testcase.retransform_class` to `test.apache.skywalking.apm.testcase.retransform` and changing the content in `spring-mvc-servlet.xml.xml`. But the ci will fail because the `serviceName` and ` spanName` has changed.  **So I want to know when the serviceName was set to `retransform-class-tomcat-scenario` and the `spanName` was changed.** I can't find the related code in `retransform-class-tomcat-scenario` and there seem to be no relevant settings in the configuration file and environment variables. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
