kezhenxu94 commented on a change in pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#discussion_r549754870
##########
File path: oap-server/server-bootstrap/src/main/resources/application.yml
##########
@@ -266,6 +266,7 @@ envoy-metric:
# to append the version number to the service name.
# Be careful, when using environment variables to pass this configuration,
use single quotes(`''`) to avoid it being evaluated by the shell.
k8sServiceNameRule: ${K8S_SERVICE_NAME_RULE:"${service.metadata.name}"}
+ enabledMALRules: ${SW_ENVOY_METRIC_MAL_RULES:"envoy"}
Review comment:
> Why need this? Could we disable through `SW_ENVOY_METRIC=-`?
We could disable through `SW_ENVOY_METRIC=-` but I thought this was not for
disabling, it shares the same idea as
https://github.com/apache/skywalking/issues/5853 , we may need this for the
same reason as #5853 , do we?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
