kezhenxu94 commented on a change in pull request #113:
URL: https://github.com/apache/skywalking-python/pull/113#discussion_r550240975
##########
File path: skywalking/agent/__init__.py
##########
@@ -73,6 +73,15 @@ def __fini():
def start():
+ flag = False
+ try:
+ from gevent import monkey
+ flag = monkey.is_module_patched("socket")
+ except Exception as e:
+ logger.warning("check gevent error:%s", e)
+ if flag:
+ import grpc.experimental.gevent as grpc_gevent
+ grpc_gevent.init_gevent()
Review comment:
OK I can get you point, sounds good to me, can you please slightly
polish line 80-81 so that the warning logs are only printed when `monkey`
really exists in users application, at the moment, it seems that when there is
no `monkey` package installed, it prints the warning logs? I think that's
confusing for users, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
