libinglong commented on a change in pull request #6103:
URL: https://github.com/apache/skywalking/pull/6103#discussion_r550260399
##########
File path:
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/plugin/WitnessClassFinder.java
##########
@@ -36,6 +36,17 @@
* @return true, if the given witnessClass exists, through the given
classLoader.
*/
public boolean exist(String witnessClass, ClassLoader classLoader) {
+ return getResolution(witnessClass, classLoader)
Review comment:
Maybe It should not be assumed that the put method for a key has no
effect on the get method for another key In concurrent environment as long as
the data struct(hashmap) is thread unsafe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
