tom-pytel commented on issue #6109: URL: https://github.com/apache/skywalking/issues/6109#issuecomment-752801256
> `e06e5c5` is truly set the component id as HTTP, and it exists still > https://github.com/apache/skywalking-nodejs/blob/c491d5cbdbea965a4ed640a93d9c232fafb99056/src/plugins/HttpPlugin.ts#L76-L80 And in the same way testing for `span.depth === 1` yes, except I think the difference may be that the higher level span has ended and so the `depth` will be `1` where it was not before since this was changed to `onFinished()` it is probably processed in a different order from before. In any case, you can see the different behavior in the images I sent up, the earler tags as `express` and the new one as `Http`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
