zifeihan commented on issue #6114:
URL: https://github.com/apache/skywalking/issues/6114#issuecomment-753304624


   > > config server(nacos,zk) <--update Event--> OAP --command--> agent
   > > did I get that right?
   > 
   > Yes, but we need more details about how to make this happens. Such as
   > 
   > 1. The gRPC service between agent and OAP
   > 2. How to define the configuration of every service in the configuration 
center. Such as, do you provide one key with a YAML as value for all services?
   > 3. How the agent core and plugin declare the config is changeable, and 
listening to the change event from the command.
   
   for 2, How about we define an agent-dynamic-config.yml, in which the 
relationship between service and dynamic configuration is stored. The content 
of the file can be modified in the configuration center. every config key same 
as agent.config item, like this,
   ```
   dynamic-configs:
     order-service:
       trace.sample_rate: 1000
       trace.ignore_path: /api/seller/seller/*
       otherConfig: ...
     pay-service:
       trace.sample_rate: 0
       trace.ignore_path: /eureka/**
   ```
   for 3, I want to add a ConfigWatcherRegister similar to OAP for the agent, 
but need to specify the name of the configuration item in the agent.config.
   
   hope some suggestions, and looking forward to a better way.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to