tom-pytel commented on pull request #20: URL: https://github.com/apache/skywalking-nodejs/pull/20#issuecomment-753323425
> > In the case here what happens is that the axios request is about to return synchronously so it calls `span.async()` to remove itself from the current async task span list > > From what I've tested, if you remove itself (by `span.async()`), the underlying `http` module will create a new span instead of using the existing exit span, so the result becomes Hmm, this is what I meant when I said the interaction with the `http` module is tricky. This needs to be solved correctly for both cases so I suggest the following for now since we should get this express fix done - Since removing these calls is not causing problems at the moment, though it may in theory, don't remove but rather comment out the async() and resync() and leave them in the code along with a short comment TODO describing this situation. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
