wu-sheng commented on a change in pull request #6091: URL: https://github.com/apache/skywalking/pull/6091#discussion_r550850337
########## File path: docs/en/setup/envoy/metrics_service_setting.md ########## @@ -39,6 +39,17 @@ A more complete static configuration, can be observed [here](config.yaml). Note that Envoy can also be configured dynamically through [xDS Protocol](https://github.com/envoyproxy/data-plane-api/blob/master/XDS_PROTOCOL.md). +**Attention**: Only use this when Envoy is under Istio's control, because SkyWalking needs to parse the service name and service instance name from the metadata that is injected by Istio. However, if you want to use this without Istio, you need to inject the metadata yourself like this: Review comment: cc @hanahmily Due to share the same node id mechanism, even we don't require header exchange in the metrics service analysis. We will still depend on Istio control. We fetch the name based on that. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
