kezhenxu94 commented on a change in pull request #2:
URL: https://github.com/apache/skywalking-infra-e2e/pull/2#discussion_r551002297
##########
File path: commands/setup/setup.go
##########
@@ -18,15 +18,36 @@
package setup
import (
- "fmt"
+ "github.com/apache/skywalking-infra-e2e/internal/components/setup"
+ "github.com/apache/skywalking-infra-e2e/internal/logger"
"github.com/spf13/cobra"
+
+ "github.com/apache/skywalking-infra-e2e/internal/flags"
)
+func init() {
+ Setup.Flags().StringVar(&flags.Env, "env", "kind", "specify the run
environment")
+ Setup.Flags().StringVar(&flags.File, "file", "kind.yaml", "specify
configuration file")
+}
+
var Setup = &cobra.Command{
Use: "setup",
Short: "",
Run: func(cmd *cobra.Command, args []string) {
Review comment:
FYI @fgksgf 👆, let's propagate the errors to the up-most command
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
