wu-sheng commented on a change in pull request #6188:
URL: https://github.com/apache/skywalking/pull/6188#discussion_r555729215
##########
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/config/NamingControl.java
##########
@@ -95,6 +95,10 @@ public String formatInstanceName(String instanceName) {
* @return the string, which length less than or equals {@link
#endpointNameMaxLength};
*/
public String formatEndpointName(String serviceName, String endpointName) {
+ if (endpointName == null) {
+ return null;
+ }
Review comment:
I think you forget the null/empty check for service Name.
##########
File path:
oap-server/analyzer/agent-analyzer/src/main/java/org/apache/skywalking/oap/server/analyzer/provider/trace/parser/listener/MultiScopesAnalysisListener.java
##########
@@ -310,6 +312,7 @@ public void build() {
slowDatabaseAccesses.forEach(sourceReceiver::receive);
Review comment:
I think you miss this one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
