wu-sheng commented on a change in pull request #6188:
URL: https://github.com/apache/skywalking/pull/6188#discussion_r557011256
##########
File path:
oap-server/analyzer/agent-analyzer/src/main/java/org/apache/skywalking/oap/server/analyzer/provider/trace/parser/listener/MultiScopesAnalysisListener.java
##########
@@ -62,7 +61,7 @@
public class MultiScopesAnalysisListener implements EntryAnalysisListener,
ExitAnalysisListener, LocalAnalysisListener {
private final List<SourceBuilder> entrySourceBuilders = new
ArrayList<>(10);
private final List<SourceBuilder> exitSourceBuilders = new ArrayList<>(10);
- private final List<DatabaseSlowStatement> slowDatabaseAccesses = new
ArrayList<>(10);
+ private final List<SourceBuilder> slowDatabaseAccessesBuilders = new
ArrayList<>(10);
Review comment:
Don't change this. My meaning is, `DatabaseSlowStatement` should have
related name fields(used to have IDs only), and do `#prepare` too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
