buxingzhe commented on a change in pull request #6188:
URL: https://github.com/apache/skywalking/pull/6188#discussion_r557168517
##########
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/source/DatabaseSlowStatement.java
##########
@@ -21,16 +21,26 @@
import lombok.Getter;
import lombok.Setter;
import org.apache.skywalking.oap.server.core.Const;
+import org.apache.skywalking.oap.server.core.analysis.IDManager;
+import org.apache.skywalking.oap.server.core.analysis.NodeType;
+import org.apache.skywalking.oap.server.core.config.NamingControl;
import static
org.apache.skywalking.oap.server.core.source.DefaultScopeDefine.DATABASE_SLOW_STATEMENT;
@ScopeDeclaration(id = DATABASE_SLOW_STATEMENT, name = "DatabaseSlowStatement")
public class DatabaseSlowStatement extends Source {
+ @Setter
+ private NamingControl namingControl;
Review comment:
Actually I'd like to do like `SourceBuilder`, but
`DatabaseSlowStatement` must have the default construstor, just referring to
`DispatcherManager.addIfAsSourceDispatcher` line#97.
Another way is I declare two constructors in `DatabaseSlowStatement`, i.e.
the default and with `NamingControl`, what do you think of that?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
